This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Pagecontainer: Remove unnecessary $( ":focus" ) fallback on page change #7927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9845702 to
f0cb08d
Compare
| @@ -939,7 +939,7 @@ define( [ | |||
| historyDir, pageTitle, isDialog, | |||
| alreadyThere, newPageTitle, | |||
| params, cssTransitionDeferred, | |||
| beforeTransition; | |||
| beforeTransition, focusElement; | |||
There was a problem hiding this comment.
Follow style guide for variable declarations
There was a problem hiding this comment.
I'm not sure what you mean here. Variables that are not being initialized are being listed together at the beginning of the declaration, subsequent lines are indented, the new variable uses complete words. Where does this deviate from the style guide?
78a24f2 to
3ede368
Compare
1 similar comment
1 similar comment
This was referenced Feb 19, 2015
This is now part of the enhancer module also removes tests for this and the page based enhancer
reproducible with current code.
|
Can you also land this on 1.5-dev please |
3ede368 to
5178395
Compare
|
Reopened as #8154 against 1.5-dev. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1560